Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default SCC directory #16256

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Conversation

hangshao0
Copy link
Contributor

@hangshao0 hangshao0 commented Nov 3, 2022

Change the default SCC directory on Linux, AIX and MacOS to $HOME/.cache/javasharedresources/

Depends on eclipse-openj9/openj9-docs#1016
Closes #11417

Signed-off-by: Hang Shao hangshao@ca.ibm.com

Change the default SCC directory on Linux, AIX and MacOS to 
$HOME/.cache/javasharedresources/

Closes eclipse-openj9#11417

Signed-off-by: Hang Shao <hangshao@ca.ibm.com>
@hangshao0
Copy link
Contributor Author

hangshao0 commented Nov 3, 2022

Tested on:
Java 8 Linux_x64, sanity.functional and extended.functional
Java 11 AIX PPC64, sanity.functional and extended.functional
All passed.

Documentation issue is eclipse-openj9/openj9-docs#1016

@dsouzai
Copy link
Contributor

dsouzai commented Nov 3, 2022

Once this change is in, $HOME/javasharedresources will need to be deleted from all the farm machines since I don't think it'll automatically get deleted with -Xshareclasses:destroyAll right?

@hangshao0
Copy link
Contributor Author

Once this change is in, $HOME/javasharedresources will need to be deleted from all the farm machines since I don't think it'll automatically get deleted with -Xshareclasses:destroyAll right?

No, it won't be deleted by -Xshareclasses:destroyAll after this change is merged. Our documentation will be updated to suggest users to delete the stale cache files and directory.

I remember we run -Xshareclasses:destroyAll to clean up the shared cache before and after each test. so we may not need to worry about the cache files. But for the directory $HOME/javasharedresources itself, we may need cleanup job to delete it. FYI @llxia @AdamBrousseau

@pshipton
Copy link
Member

pshipton commented Nov 3, 2022

The doc says non-z/OS. Why not z/OS? Non-persistent control files should also go under .cache.

@hangshao0
Copy link
Contributor Author

https://www.eclipse.org/openj9/docs/xshareclasses/#cachedir

On z/OS, the default directory is /tmp/javasharedresources, not under home.

It was changed back to /tmp/javasharedresources from home by #13438.

@pshipton
Copy link
Member

pshipton commented Nov 3, 2022

jenkins compile aix,xmac jdk8

@pshipton
Copy link
Member

pshipton commented Nov 3, 2022

jenkins compile alinux64,amac jdk17

@pshipton
Copy link
Member

pshipton commented Nov 3, 2022

We can't rely on the tests having cleaned up $HOME/javasharedresources. I looked at one idle xlinux machine and found the following, two of which are old. The size is deceiving as they are sparse files, but still worth cleaning up at some point.

-rw------- 1 jenkins jenkins 314572800 Feb 19  2019 C290M11F1A64P_sharedcc_jenkins_G35
-rw------- 1 jenkins jenkins 314572800 Nov  3 20:01 C290M11F1A64P_sharedcc_jenkins_G43L00
-rw------- 1 jenkins jenkins 314572800 Oct  7 18:04 C290M17F1A64P_sharedcc_jenkins_G43L00

21M	javasharedresources/C290M11F1A64P_sharedcc_jenkins_G35
24M	javasharedresources/C290M11F1A64P_sharedcc_jenkins_G43L00
2.7M	javasharedresources/C290M17F1A64P_sharedcc_jenkins_G43L00

@hangshao0
Copy link
Contributor Author

Maybe the cleanup job should be updated to run -Xshareclasses:destroyAll. But it is not guaranteed to be a clean solution, depending on the version of default Java on the machine. e.g if it is Java 11, it will not be able to delete a Java 20 shared cache that is left over on the machine.

@pshipton
Copy link
Member

pshipton commented Nov 3, 2022

$HOME/javasharedresources will need to be deleted from all the farm machines

To clarify, only jenkins / OpenJ9 is affected. IBM Java / vmfarm is not.

@pshipton pshipton merged commit db6aad2 into eclipse-openj9:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider changing the default javasharedresources directory directly in $HOME
3 participants