Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AArch64: Fix getArgPointer() for FFI upcall #16268

Merged
merged 1 commit into from Nov 8, 2022

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Nov 7, 2022

This commit fixes getArgPointer() for AArch64.

Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com

This commit fixes getArgPointer() for AArch64.

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@knn-k
Copy link
Contributor Author

knn-k commented Nov 7, 2022

Jenkins test sanity alinux64,amac jdk19

@knn-k knn-k marked this pull request as ready for review November 7, 2022 10:28
@ChengJin01
Copy link
Contributor

Reviewer: @zl-wang
FYI: @0xdaryl

@ChengJin01 ChengJin01 added the project:panama Used to track Project Panama related work label Nov 7, 2022
@knn-k
Copy link
Contributor Author

knn-k commented Nov 7, 2022

I would like this PR to be reviewed and merged, although it fixes Issue #16237 only partially.

Copy link
Contributor

@zl-wang zl-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zl-wang
Copy link
Contributor

zl-wang commented Nov 8, 2022

i saw it was tested too. merge ...

@zl-wang zl-wang merged commit 90c8930 into eclipse-openj9:master Nov 8, 2022
@knn-k knn-k deleted the aarch64upcallFix1 branch November 8, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch:aarch64 comp:vm project:panama Used to track Project Panama related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants