Disable TM when generating portable code #16282
Conversation
| J9::CompilerEnv::initializeRelocatableTargetEnvironment() | ||
| { | ||
| OMR::CompilerEnvConnector::initializeRelocatableTargetEnvironment(); | ||
| if (J9_ARE_ANY_BITS_SET(javaVM->extendedRuntimeFlags2, J9_EXTENDED_RUNTIME2_ENABLE_PORTABLE_SHARED_CACHE)) |
There was a problem hiding this comment.
I verified that at the time this is called, the J9_EXTENDED_RUNTIME2_ENABLE_PORTABLE_SHARED_CACHE flag does get set.
| @@ -1057,7 +1057,7 @@ TR_SharedCacheRelocationRuntime::checkAOTHeaderFlags(const TR_AOTHeader *hdrInCa | |||
| { | |||
| bool defaultMessage = true; | |||
|
|
|||
| if (!TR::Compiler->target.cpu.isCompatible(hdrInCache->processorDescription)) | |||
| if (!TR::Compiler->relocatableTarget.cpu.isCompatible(hdrInCache->processorDescription)) | |||
There was a problem hiding this comment.
Strictly speaking, the target should be a superset of the relocatableTarget, so even if the relocatable target of the code in the SCC wasn't compatible with the relocatable target of the running JVM, but it is compatible with the target of the running JVM, it is ok to run the code. However, we probably don't want to allow such a scenario, so I figure it's probably best to use the relocatable target.
|
@mpirvu could you please review. |
Instead of waiting until createAOTHeader to initialize the relocatableTarget if running in portable SCC mode, check the the portable SCC flag when the CompilerEnv object is initialized. Additionally, use the relocatableTarget in RelocationRuntime for all the various checks. Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
dsouzai
force-pushed
the
fixPortableAOTTM
branch
from
0c7acd0
to
9cc2466
Compare
|
jenkins test sanity plinux,xlinux,zlinux jdk17 |
Hardware TM is not guaranteed to be available on all machines, therefore, the compiler should not use said feature when generating portable code. Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
dsouzai
force-pushed
the
fixPortableAOTTM
branch
from
9cc2466
to
b86eb77
Compare
|
jenkins test sanity plinux,xlinux,zlinux jdk17 |
|
@mpirvu should be good to merge |
This PR disables the TM feature when generating portable code.
Fixes #16009