CRIU invokes j9sysinfo_get_env() to avoid checkpoint failure #16283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonFengJ9
force-pushed
the
sssd2
branch
2 times, most recently
from
0c95e99
to
249c530
Compare
hangshao0
reviewed
Nov 10, 2022
When SSSD is enabled, j9sysinfo_get_username/getpwuid can cause checkpoint failure, these methods will be skipped if a checkpoint can be taken, j9sysinfo_get_env is used instead; Add sysinfoGetUserNameHelper to wrap j9sysinfo_get_username() and j9sysinfo_get_env() calls; Add J9PORT_CTLDATA_CRIU_SUPPORT_FLAGS to set CRIU status enabled & final restore via j9port_control accordingly; Add Trc_PRT_j9shmem_getDir_tryHomeDirFailed_notFinalRestore. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
tajila
approved these changes
Nov 21, 2022
|
jenkins test sanity win jdk8 |
|
Jenkins test sanity xlinuxcriu jdk17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRIU invokes
j9sysinfo_get_env()to avoid checkpoint failureWhen
SSSDis enabled,j9sysinfo_get_username/getpwuidcan cause checkpoint failure, these methods will be skipped if a checkpoint can be taken,j9sysinfo_get_envis used instead;Add
sysinfoGetUserNameHelperto wrapj9sysinfo_get_username()andj9sysinfo_get_env()calls;Add
J9PORT_CTLDATA_INSTANTON_FLAGSto setCRIUstatus enabled & final restore viaj9port_controlaccordingly.FYI @hangshao0
Signed-off-by: Jason Feng fengj@ca.ibm.com