Update OpenJ9 build for Windows #16334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AdamBrousseau please review, thank you!. |
vsebe
force-pushed
the
openj9_win2019
branch
from
ce756f6
to
9191983
Compare
|
Jenkins compile win jdk8,jdk11,jdk17 |
vsebe
force-pushed
the
openj9_win2019
branch
2 times, most recently
from
461920d
to
ec852e0
Compare
|
Jenkins compile win jdk8,jdk11,jdk17 |
There was a problem hiding this comment.
This is good with me now. I would like a sign-off from @pshipton as well though. Once we let it soak a few days we can roll out more machines and delete the old ones, also pending Pete's approval.
AdamBrousseau
approved these changes
Dec 6, 2022
pshipton
reviewed
Dec 6, 2022
buildenv/jenkins/common/build.groovy
Outdated
| println("Attempt to recompile, retry: ${retryCounter}") | ||
|
|
||
| try { | ||
| _ sh "make clean && ${get_compile_command()}" |
There was a problem hiding this comment.
There is an underscore in the first column here?
There was a problem hiding this comment.
Good catch, thank you!
Removed.
pshipton
reviewed
Dec 6, 2022
buildenv/jenkins/common/build.groovy
Outdated
| return false | ||
| } | ||
|
|
||
| def recompile(startTime) { |
There was a problem hiding this comment.
Did we want to do something with startTime, such as print it out?
There was a problem hiding this comment.
Otherwise it's not used, so could be removed?
Update configuration for windows platform, switch bootjdk installation directory to default location (home directory) for Windows machines. Add optional error handling for intermittent failures. Signed-off-by: Violeta Sebe <vsebe@ca.ibm.com>
|
jenkins compile win jdk8 |
pshipton
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update configuration for windows platform, switch bootjdk installation
directory to default location (home directory) for Windows machines.
Add optional error handling for intermittent failures.
Signed-off-by: Violeta Sebe vsebe@ca.ibm.com