Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unset Valhalla modifiers in Class.toGenericString() #16335

Merged
merged 1 commit into from Nov 22, 2022
Merged

Unset Valhalla modifiers in Class.toGenericString() #16335

merged 1 commit into from Nov 22, 2022

Conversation

hangshao0
Copy link
Contributor

  1. Add "primitive"/"value" for primitive VT and value classes.
  2. Unset Valhalla modifiers before calling Modifier.toString()
  3. Modify test_getModifiers_classTypes to recognize Modifer.IDENTITY

Closes #16327
Closes #16319

Signed-off-by: Hang Shao hangshao@ca.ibm.com

@hangshao0
Copy link
Contributor Author

The toGenericString() outputs of OpenJ9 and RI are the same with this change:

OpenJ9:

Primitive VT toGenericString() is  final primitive class ValueInt
Value Class toGenericString() is  public final value class ValueClass
Identity Class toGenericString() is  public final class java.lang.System

RI:

Primitive VT toGenericString() is  final primitive class ValueInt
Value Class toGenericString() is  public final value class ValueClass
Identity Class toGenericString() is  public final class java.lang.System

@hangshao0 hangshao0 added project:valhalla Used to track Project Valhalla related work comp:vm comp:test labels Nov 16, 2022
@hangshao0
Unset Valhalla modifiers in Class.toGenericString()
4f81c68 
1. Add "primitive"/"value" for primitive VT and value classes.
2. Unset Valhalla modifiers before calling Modifier.toString()
3. Modify test_getModifiers_classTypes to recognize Modifer.IDENTITY

Closes eclipse-openj9#16327
Closes eclipse-openj9#16319

Signed-off-by: Hang Shao <hangshao@ca.ibm.com>
@tajila
Copy link
Contributor

tajila commented Nov 22, 2022

jenkins test sanity amac jdk17

@tajila
Copy link
Contributor

tajila commented Nov 22, 2022

Jenkins test sanity,extended xlinuxval jdknext

@tajila tajila merged commit 55c52ff into eclipse-openj9:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tajila tajila tajila left review comments

Assignees
No one assigned
Labels
comp:test comp:vm project:valhalla Used to track Project Valhalla related work
Projects
None yet
Milestone
No milestone
2 participants
@hangshao0 @tajila