Update the verifier to recognize new constructor <vnew> of value type #16355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The VT constructors are compiled into <vnew>. Update all places using <new> to <vnew>. 1. Enable all the code inside J9VM_OPT_VALHALLA_NEW_FACTORY_METHOD. 2. Remove obsolete code that checks <init> as VT constructor. Closes eclipse-openj9#14959 Signed-off-by: Hang Shao <hangshao@ca.ibm.com>
hangshao0
added
comp:vm
project:valhalla
|
There is a corresponding JIT PR: #16357. |
|
@ChengJin01 Please review these changes |
|
FYI @ehrenjulzert This PR enables the code to handle new VT factory method. |
|
As talked to @hangshao0, there is no special concern from my side as it just enables the previously implemented code to deal with the new keyword |
ChengJin01
approved these changes
Nov 28, 2022
|
Jenkins test sanity,extended xlinuxval jdknext |
|
Jenkins test sanity win jdk8 |
|
Jenkins test sanity plinuxvalst jdknext |
tajila
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<vnew>. Update all places using<new>to<vnew>.<init>as VT constructor.issue #14959
Signed-off-by: Hang Shao hangshao@ca.ibm.com