Improve client JVM disconnect messages #16394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The messages that are printed by a client JVM when the `-XX:+JITServerLogConnections` option is specified can sometimes be misleading. For instance, if a client starts, but there is no server available, the client will print a message saying that it lost connection to the server, where in fact, it was never connected to a server. In other cases there could be a transient error that one of the compilation thread experiences and the client will issue a "Lost connection to the server" message, but the other compilation threads continue to compile remotely just fine. This commit fixes the issues mentioned above. Issue: eclipse-openj9#16381 Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
|
Example of messages when the server dies while the client compiles remotely: Note that after the read error the client closes its socket and retries the same compilation remotely. THis is done because sometimes the networking error is cleared very fast. However, in this example the server is dead so the client fails to connect to the server and displays the "Lost connection" message. The compilation is tried again, this time locally. |
|
@dsouzai Could you please review/merge this PR? Thanks |
|
jenkins test sanity xlinuxjit jdk17 |
|
I had an experiment where the server threw an exception on purpose when a message with a certain seqNo is received. The client aborted the compilation, tried it again remotely, and the server finished successfully. This behavior is better than the previous one where the client would disconnect and try connect after 2 seconds. |
dsouzai
approved these changes
Nov 30, 2022
|
5 failures: Again, a bunch of FSD mode failures and I am sure that this PR couldn't have caused them. |
|
10 grinders of each failed target shows no problems whatsoever: https://openj9-jenkins.osuosl.org/job/Grinder/1570/ |
|
Quite possibly, though I don't understand why they show up so often nowadays in "jenkins test sanity". I used to do such testing over the summer/fall without hitting them. |
|
I haven't been recording the newest instances of #14704, but such failures do still occur in the nightly tests. I think the most recent test failure in one of the |
|
jenkins test sanity plinuxjit zlinuxjit jdk17 |
|
jenkins test sanity plinuxjit,zlinuxjit jdk17 |
|
Started grinder of 100 runs of |
|
It only ran once in grinder and then it hit an infra issue: |
|
100 grinder runs for |
|
Tests on Z/P failed due to infra |
|
jenkins test sanity plinuxjit,xlinuxjit,zlinuxjit jdk17 |
|
Test on P and Z passed. Tests on x86 timed-out in |
|
Since the error showing on xlinux are not generated by this PR, I think that this PR can be merged. |
This was referenced Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The messages that are printed by a client JVM when the
-XX:+JITServerLogConnectionsoption is specified can sometimes be misleading. For instance, if a client starts, but there is no server available, the client will print a message saying that it lost connection to the server, where in fact, it was never connected to a server. In other cases there could be a transient error that one of the compilation thread experiences and the client will issue a "Lost connection to the server" message, but the other compilation threads continue to compile remotely just fine. This commit fixes the issues mentioned above.Issue: #16381
Signed-off-by: Marius Pirvu mpirvu@ca.ibm.com