Add unit test for accelerated CRC32C.update on Z #16404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spencer-Comin
force-pushed
the
crc32c-functional-test
branch
from
227dc2c
to
c4e2a2c
Compare
Spencer-Comin
force-pushed
the
crc32c-functional-test
branch
from
c4e2a2c
to
ca887be
Compare
Spencer-Comin
changed the title
Spencer-Comin
force-pushed
the
crc32c-functional-test
branch
from
ca887be
to
12210b7
Compare
r30shah
requested changes
Dec 13, 2022
Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
Spencer-Comin
force-pushed
the
crc32c-functional-test
branch
from
12210b7
to
d5adff3
Compare
joransiu
reviewed
Jan 23, 2023
|
@llxia Ping to check if you get chance to review Spencer's changes ? Would appreciate if you merge them if you are OK with changes. |
|
Sorry, this slipped off my radar. |
|
This doesn't compile on Java 8 since there is no java.util.zip.CRC32C |
|
Until it can be fixed, reverted via #16697 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for correctness in accelerated CRC-32C calculation recently implemented for Z #16379.