Remove invalid arch.s390x #16405
Merged
Remove invalid arch.s390x #16405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arch.s390x is invalid. We should use arch.390. Since testJITServer is currently running and passing on zlinux, update platformRequirements to avoid confusion. Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
keithc-ca
reviewed
Dec 1, 2022
| @@ -747,7 +747,7 @@ | |||
| echo $(Q)$(TEST_JDK_BIN)$(D)jitserver doesn't exist; assuming this JDK does not support JITServer and trivially passing the test.$(Q); \ | |||
| fi; \ | |||
| $(TEST_STATUS)</command> | |||
| <platformRequirements>os.linux,^arch.arm,^arch.aarch64,^arch.s390x,bits.64</platformRequirements> | |||
| <platformRequirements>os.linux,^arch.arm,^arch.aarch64,bits.64</platformRequirements> | |||
There was a problem hiding this comment.
It would seem that the intent of #10876 was only to enable this test on Power, but because there is no arch.s390x architecture, it was also enabled for arch.390, so this change seems safe.
|
This should not affect the platforms where the test runs; no need for a PR build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arch.s390x is invalid. We should use arch.390.
Since testJITServer is currently running and passing on zlinux,
update platformRequirements to avoid confusion.
Signed-off-by: Lan Xia Lan_Xia@ca.ibm.com