Fix bug while computing effective caller index #16406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on fixing the block frequnecy calculation when previous inlining may be different in [1], a bug was introduced so that a flag that would notify the caller of computeEffectiveCallerIndex upon successfully matching BCI was never set. This commit fixes that bug. [1]. eclipse-openj9@9f404be Signed-off-by: Rahil Shah <rahil@ca.ibm.com>
|
Thanks a lot @IBMJimmyk for quickly trying out the change and notifying about the issue. I have fixed the problem in this PR. @jdmpapin I apologize for this oversight from my end when addressing comments in 9f404be. I would appreciate if you can review this change. FYI @vijaysun-omr |
jdmpapin
approved these changes
Dec 1, 2022
|
Jenkins test sanity all jdk8,jdk11,jdk19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on fixing the block frequnecy calculation when previous inlining may be different in [1], a bug was introduced so that a flag that would notify the caller of computeEffectiveCallerIndex upon successfully matching BCI was never set. This commit fixes that bug.
[1]. 9f404be
Signed-off-by: Rahil Shah rahil@ca.ibm.com