Fix up potential stale pointer after GC #16414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test sanity amac jdk19 |
|
jenkins test sanity win jdk19 |
|
jenkins test sanity plinux jdk19 |
babsingh
requested changes
Dec 5, 2022
There was a problem hiding this comment.
The PR builds don't need to be relaunched. The old PR builds are still good since only the comment was updated.
- amac: https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/3109 (PASSED)
- win_x64: https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/3110 (PASSED)
- pLinux: https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/3111 (PASSED)
babsingh
reviewed
Dec 5, 2022
Fixes eclipse-openj9#16351 Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
|
jenkins test sanity amac jdk19 |
babsingh
added
backport:candidate
babsingh
approved these changes
Dec 5, 2022
keithc-ca
reviewed
Dec 5, 2022
| @@ -343,6 +343,10 @@ JVM_VirtualThreadMountEnd(JNIEnv *env, jobject thread, jboolean firstMount) | |||
| vmFuncs->setHeapOutOfMemoryError(currentThread); | |||
| goto release1; | |||
| } | |||
|
|
|||
| /* Re-fetch as the memory allocation above may have moved the object. */ | |||
| threadObj = J9_JNI_UNWRAP_REFERENCE(thread); | |||
There was a problem hiding this comment.
By the same reasoning, rootVirtualThread may have moved as well.
There was a problem hiding this comment.
rootVirtualThread cannot be moved as the GC will only occur if there is not enough space perform the requested allocation. So the allocation of rootVirtualThread would only happen after the GC.
pshipton
removed
the
backport:candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix up potential stale pointer after GC
Fixes #16351
Signed-off-by: Tobi Ajila atobia@ca.ibm.com