Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing break statement #16471

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

bhavanisn
Copy link
Contributor

@bhavanisn bhavanisn commented Dec 14, 2022

Adding the missing break statement.
Issue #11741

Signed-off by: Bhavani S N (bhavani.sn@ibm.com)

@pshipton
Copy link
Member

Pls use auto-close keywords correctly. close https://github.com/eclipse-openj9/openj9/issues/11741 (or with another keyword) must be on a line by itself.
https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests

@0xdaryl
Copy link
Contributor

0xdaryl commented Mar 2, 2023

Sorry, this PR fell through the cracks. Can you update the copyright header to 2023 and I'll launch CI testing.

@0xdaryl 0xdaryl self-assigned this Mar 2, 2023
@0xdaryl
Copy link
Contributor

0xdaryl commented Mar 2, 2023

A separate PR will eventually be needed for 0.38 once this merges.

@bhavanisn
Copy link
Contributor Author

@0xdaryl I will do that.

@bhavanisn
Copy link
Contributor Author

@0xdaryl I have changed the copyright header. Thanks.

@0xdaryl
Copy link
Contributor

0xdaryl commented Mar 2, 2023

Jenkins test sanity plinux,aix jdk17

@0xdaryl
Copy link
Contributor

0xdaryl commented Mar 3, 2023

I modified the PR comment such that it won't automatically close 11741. I want the issue to remain open until the fix lands in 0.38. @bhavanisn , please open a PR for that fix in the 0.38 release branch once this is merged.

@0xdaryl 0xdaryl merged commit a61413c into eclipse-openj9:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants