Remove wantToPatchClassPointer() and the hcrPatchClassPointers option #16481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were introduced a long time ago to allow a certain change to be toggled. The change was to stop generating runtime assumptions for patching class pointers on class redefinition, and to stop generating slower but more easily patchable instruction sequences to allow for those runtime assumptions. The patching was no longer needed because class redefinition had been made in-place. As a result, wantToPatchClassPointer() and hcrPatchClassPointers are no longer necessary. They are removed, and all use sites now behave as though hcrPatchClassPointers is not set and wantToPatchClassPointer() returns false.
|
This and eclipse/omr#6851 will require a coordinated merge. |
|
Jenkins test sanity all jdk8,jdk11,jdk17 depends eclipse/omr#6851 |
|
Both failing CI jobs are variants of #13577. |
0xdaryl
approved these changes
Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were introduced a long time ago to allow a certain change to be toggled. The change was to stop generating runtime assumptions for patching class pointers on class redefinition, and to stop generating slower but more easily patchable instruction sequences to allow for those runtime assumptions. The patching was no longer needed because class redefinition had been made in-place.
As a result,
wantToPatchClassPointer()andhcrPatchClassPointersare no longer necessary. They are removed, and all use sites now behave as thoughhcrPatchClassPointersis not set andwantToPatchClassPointer()returns false.