Use assertion with message to simplify debugging #16507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amicic
approved these changes
Jan 3, 2023
|
Jenkins signed off by check |
|
Jenkins compile win,aix jdk19 |
|
lost test build results in attempts to re-run ip-validation, all tests have passed |
Currently regular assertion is used in MM_GCExtensions::releaseNativesForContinuationObject(). Replace it to assertion with message to simplify debugging process: print Continuation object address as well as address of J9VMContinuation structure. Signed-off-by: Dmitri Pivkine <Dmitri_Pivkine@ca.ibm.com>
Specifically: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently regular assertion is used in
MM_GCExtensions::releaseNativesForContinuationObject(). Replace it to assertion with message to simplify debugging process: print Continuation object address as well as address of J9VMContinuation structure.
Signed-off-by: Dmitri Pivkine Dmitri_Pivkine@ca.ibm.com