Initial CRIU serviceability infrastructure #16528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsouzai
added
comp:jit
comp:jitserver
Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
dsouzai
force-pushed
the
externalOptions
branch
from
2cca9b6
to
7315480
Compare
ymanton
approved these changes
Jan 13, 2023
dsouzai
force-pushed
the
externalOptions
branch
from
7315480
to
59bd661
Compare
|
@ymanton made requested changes (see force push). |
Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
dsouzai
force-pushed
the
externalOptions
branch
from
59bd661
to
e44143d
Compare
|
Missed the part about adding the file name, did so in this force push. |
|
@ymanton good for review again. |
ymanton
approved these changes
Jan 16, 2023
|
Jenkins test sanity.functional xlinux,plinux,zlinux,alinux64 jdk11 |
|
plinux and xlinux have failed because of I believe because the UNB machines are down. |
|
https://openj9.slack.com/archives/CDS7QE9HB/p1673907333439259 |
|
Jenkins test sanity.functional xlinux,plinux jdk11 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Options passed to the JVM are consumed by the JIT in different places and at different points during the bootstrap process. However, often the string literals that are used for the comparison are scattered across various locations. This is particularly problematic for something like the CRIU feature where we may need to process options post restore.
This PR gathers all the string literals and puts them in an array. The reason for doing this, rather than just have them be a bunch of
#defines in a header file, is so that for the CRIU feature post restore options processing, we can just iterate over the array and explicitly decide what we want to do with the option.This PR introduces a new enum class called
TR::ExternalOptions, wherein each enum value has a 1-1 mapping with the string literal associated with the VM option consumed by the JIT.This PR also introduces the
JIT_METADATA_IS_PRECHECKPOINT_COMPflag that is set on theJ9JITExceptionTableto indicate whether a compilation was performed pre-checkpoint.