-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated 0.36.0 release notes #16546
Updated 0.36.0 release notes #16546
Conversation
Created draft 0.36.0 release notes Updated the commit history link [skip ci] Signed-off-by: Sreekala Gopakumar <sreekala.gopakumar@ibm.com>
I think it could use more context and should probably be moved to the Known Issues table, since it's kind of a limitation. You could add a row with:
|
Re "before the release of OpenJDK 20 in April". OpenJDK will release OpenJDK 20 in March, and 20.0.1 in April. The importance of the April release is that is when new security vulnerabilities are disclosed. jdk20 is updated in 20.0.1 with fixes for the security vulnerabilities, but jdk19 will be out of support and not updated, any old build will therefore contain known security vulnerabilities once the April vulnerabilities are announced. |
doc/release-notes/0.36/0.36.md
Outdated
<tr> | ||
<td valign="top"><a href="https://github.com/eclipse-openj9/openj9/issues/16133">#16133</a></td> | ||
<td valign="top">New <tt>-XX:[+|-]MergeCompilerOptions</tt> option is added to enable or disable the merging of multiple -Xjit or -Xaot options into a single -Xjit or -Xaot option.</td> | ||
<td valign="top">All versions (Linux)</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't limited to Linux, it affects all platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some small suggestions for the proposed text
There is a new issue I created that should go in. eclipse-openj9/openj9-docs#1037 |
doc/release-notes/0.36/0.36.md
Outdated
<td valign="top"><a href="https://github.com/eclipse-openj9/openj9/issues/16166">#16166</a></td> | ||
<td valign="top">Default JITServer AOT cache is named as <tt>default</tt>.</td> | ||
<td valign="top">All versions (Linux)</td> | ||
<td valign="top">A JITServer instance can have several AOT caches, each with its own name. Client JVMs with different profiles of execution can specify a particular AOT cache name with the <tt>-XX:JITServerAOTCacheName</tt> option to use the same JITServer instance. Earlier, if the cache name was not specified in this option, the default was to use a nameless cache. The default AOT cache name is now changed to <tt>default</tt>.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I am picky, but reading again this sentence:
"Client JVMs with different profiles of execution can specify a particular AOT cache name with the -XX:JITServerAOTCacheName option to use the same JITServer instance."
it makes me think that it could be misinterpreted as "if you want two clients to connect to the same JITServer instance you must use XX:JITServerAOTCacheName
"
Enforcing two clients to connect to the same JITServer instance is done by specifying the same JITServer address.
The paragraph should convey that, if two clients with different profiles of execution connect to the same JITServer instance, they should target different AOT caches with the XX:JITServerAOTCacheName
option, caches that contain methods optimized based on their own execution profile.
A suggestion for rephrasing:
A JITServer instance can have several AOT caches, each with its own name. The -XX:JITServerAOTCacheName option allows client JVMs with different profiles the execution to connect to the same JITServer instance, but access different versions of compiled methods optimized for their own profile. Earlier, if the cache name was not specified in this option, the default was to use a nameless cache. The default AOT cache name is now changed to default.
The year in the copyright notice needs to be changed to 2023 |
Updated 0.36.0 release notes [skip ci] Signed-off-by: Sreekala Gopakumar <sreekala.gopakumar@ibm.com>
af155df
to
3dd9460
Compare
I will make the changes in the corresponding issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updated 0.36.0 release notes
[skip ci]
Signed-off-by: Sreekala Gopakumar sreekala.gopakumar@ibm.com