Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated 0.36.0 release notes #16546

Merged
merged 3 commits into from
Jan 16, 2023

Conversation

Sreekala-Gopakumar
Copy link
Contributor

Updated 0.36.0 release notes

[skip ci]

Signed-off-by: Sreekala Gopakumar sreekala.gopakumar@ibm.com

Created draft 0.36.0 release notes
Updated the commit history link

[skip ci]

Signed-off-by: Sreekala Gopakumar <sreekala.gopakumar@ibm.com>
@Sreekala-Gopakumar
Copy link
Contributor Author

@doveye @pshipton - Updated 0.36.0 release notes. Please check and confirm. Thanks!

@doveye
Copy link
Contributor

doveye commented Jan 12, 2023

I think it could use more context and should probably be moved to the Known Issues table, since it's kind of a limitation. You could add a row with:

  • Issue Number - just a dash
  • Description - something like: "Support for JDK19 is not yet available due to outstanding issues, as listed in the milestone 35 plan.
  • Platform - all
  • Impact - something like: "JDK19 support will be added in a future OpenJ9 release if possible before the release of OpenJDK 20 in April. This work might delay support for JDK20 (you can follow the progress of JDK20 support in the milestone 40 plan). The information in the Eclipse OpenJ9 releases table in the documentation is therefore more likely to change than usual.
  • Workaround - none

@pshipton
Copy link
Member

pshipton commented Jan 12, 2023

Re "before the release of OpenJDK 20 in April". OpenJDK will release OpenJDK 20 in March, and 20.0.1 in April.

The importance of the April release is that is when new security vulnerabilities are disclosed. jdk20 is updated in 20.0.1 with fixes for the security vulnerabilities, but jdk19 will be out of support and not updated, any old build will therefore contain known security vulnerabilities once the April vulnerabilities are announced.

@pshipton pshipton requested a review from mpirvu January 12, 2023 15:52
<tr>
<td valign="top"><a href="https://github.com/eclipse-openj9/openj9/issues/16133">#16133</a></td>
<td valign="top">New <tt>-XX:[+|-]MergeCompilerOptions</tt> option is added to enable or disable the merging of multiple -Xjit or -Xaot options into a single -Xjit or -Xaot option.</td>
<td valign="top">All versions (Linux)</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't limited to Linux, it affects all platforms.

Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some small suggestions for the proposed text

doc/release-notes/0.36/0.36.md Outdated Show resolved Hide resolved
doc/release-notes/0.36/0.36.md Outdated Show resolved Hide resolved
@Sreekala-Gopakumar
Copy link
Contributor Author

@doveye @pshipton @mpirvu - Updated 0.36.0 release notes. Please check and confirm. Thanks!

@pshipton
Copy link
Member

There is a new issue I created that should go in. eclipse-openj9/openj9-docs#1037

@pshipton pshipton self-requested a review January 13, 2023 18:27
<td valign="top"><a href="https://github.com/eclipse-openj9/openj9/issues/16166">#16166</a></td>
<td valign="top">Default JITServer AOT cache is named as <tt>default</tt>.</td>
<td valign="top">All versions (Linux)</td>
<td valign="top">A JITServer instance can have several AOT caches, each with its own name. Client JVMs with different profiles of execution can specify a particular AOT cache name with the <tt>-XX:JITServerAOTCacheName</tt> option to use the same JITServer instance. Earlier, if the cache name was not specified in this option, the default was to use a nameless cache. The default AOT cache name is now changed to <tt>default</tt>.</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I am picky, but reading again this sentence:
"Client JVMs with different profiles of execution can specify a particular AOT cache name with the -XX:JITServerAOTCacheName option to use the same JITServer instance."
it makes me think that it could be misinterpreted as "if you want two clients to connect to the same JITServer instance you must use XX:JITServerAOTCacheName"
Enforcing two clients to connect to the same JITServer instance is done by specifying the same JITServer address.
The paragraph should convey that, if two clients with different profiles of execution connect to the same JITServer instance, they should target different AOT caches with the XX:JITServerAOTCacheName option, caches that contain methods optimized based on their own execution profile.

A suggestion for rephrasing:

A JITServer instance can have several AOT caches, each with its own name. The -XX:JITServerAOTCacheName option allows client JVMs with different profiles the execution to connect to the same JITServer instance, but access different versions of compiled methods optimized for their own profile. Earlier, if the cache name was not specified in this option, the default was to use a nameless cache. The default AOT cache name is now changed to default.

@mpirvu
Copy link
Contributor

mpirvu commented Jan 13, 2023

The year in the copyright notice needs to be changed to 2023

Updated 0.36.0 release notes

[skip ci]

Signed-off-by: Sreekala Gopakumar <sreekala.gopakumar@ibm.com>
@Sreekala-Gopakumar
Copy link
Contributor Author

There is a new issue I created that should go in. eclipse-openj9/openj9-docs#1037

I will make the changes in the corresponding issue.

@Sreekala-Gopakumar
Copy link
Contributor Author

@mpirvu @pshipton - I have incorporated the suggested changes. Please check and confirm. Thanks!

Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pshipton pshipton merged commit 67f6c50 into eclipse-openj9:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants