AArch64: Accelerate CRC-32 calculation #16583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akira1Saitoh
force-pushed
the
aarch64CRC2
branch
from
a44eaa4
to
957e3f9
Compare
Accelerate CRC32.update, CRC32.updateBytes and CRC32.updateByteBuffers recognized methods in addition to CRC32C methods. Signed-off-by: Akira Saitoh <saiaki@jp.ibm.com>
Akira1Saitoh
force-pushed
the
aarch64CRC2
branch
from
957e3f9
to
7068940
Compare
|
Jenkins test sanity alinux64,amac jdk17 |
knn-k
approved these changes
Jan 25, 2023
|
Openjdk tests with this PR on Linux and macOS were successful. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accelerate
CRC32.update,CRC32.updateBytesandCRC32.updateByteBuffersrecognized methods in addition to CRC32C methods.This acceleration shows ~6.5x speedup compared to the existing implementation using zlib on Linux. However, the zlib implementation is faster on Apple Silicon Mac as described in #16584. Thus, this acceleration is disabled on Mac.
Signed-off-by: Akira Saitoh saiaki@jp.ibm.com