Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only call fixHiddenOrAnonSignature in Java 17+ #16613

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Only call fixHiddenOrAnonSignature in Java 17+ #16613

merged 1 commit into from
Jan 27, 2023

Conversation

ehrenjulzert
Copy link

Fixes #16604

Signed-off-by: Ehren Julien-Neitzert ehren.julien-neitzert@ibm.com

@ehrenjulzert
Copy link
Author

@tajila @pshipton

@pshipton
Copy link
Member

Should we #if out fixHiddenOrAnonSignature as well?

jenkins compile amac jdk11

@tajila
Copy link
Contributor

tajila commented Jan 27, 2023

Yes, looks like the only caller is in jvmtiGetClassSignature

@pshipton
Copy link
Member

For some reason the test doesn't always pass, but it can pass with this fix. When it fails it's due to what looks like a network problem.

18:28:51   Target VM failed to initialize.
18:28:51  java.lang.NullPointerException
18:28:51  	at VMConnection.open(VMConnection.java:157)

Passing run: https://openj9-jenkins.osuosl.org/job/Grinder_iteration_0/204/

@pshipton
Copy link
Member

@ehrenjulzert after you add the #if around fixHiddenOrAnonSignature, pls cherry pick the fix against https://github.com/eclipse-openj9/openj9/tree/v0.36.1-release and create another PR.

Only call fixHiddenOrAnonSignature in Java 17+
2b77db3 
Fixes eclipse-openj9#16604

Signed-off-by: Ehren Julien-Neitzert <ehren.julien-neitzert@ibm.com>
@ehrenjulzert
Copy link
Author

ehrenjulzert commented Jan 27, 2023 •
edited

The #if is added in 2b77db3 , now I just need to make the other PR

@ehrenjulzert
Copy link
Author

Other PR for v0.36.1-release: #16615

@tajila
Copy link
Contributor

tajila commented Jan 27, 2023

jenkins test sanity alinux64 jdk11

@pshipton pshipton merged commit de0e456 into eclipse-openj9:master Jan 27, 2023
@pshipton pshipton mentioned this pull request Jan 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tajila tajila tajila approved these changes

@pshipton pshipton pshipton approved these changes

Assignees
No one assigned
Labels
comp:vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenJDK com/sun/jdi/ClassesByName2Test.java fails on 11.0.18
3 participants
@ehrenjulzert @pshipton @tajila