Initialize thread names in thread constructors, don't call setName() #16624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
requested changes
Jan 30, 2023
...agement/share/classes/com/ibm/lang/management/internal/MemoryNotificationThreadShutdown.java
Outdated
Show resolved
Hide resolved
test/functional/cmdLineTests/cmdLineTest_J9tests/j9tests_firstThreadName.xml
Outdated
Show resolved
Hide resolved
This avoids having a default name created. Issue eclipse-openj9#16621 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
|
Updates done. |
keithc-ca
approved these changes
Jan 30, 2023
|
Also tested locally against jdk19 which doesn't use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids having a default name created.
Fixes #16621
Built in https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-Personal/333/
Tested in https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/1903 - passed
Also ran the test on a build without the fix, which failed.
https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/1904