[Test/FFI] Remove the struct padding on Windows & zLinux #16628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified in Grinders (x10) on all supported platforms including Windows & zLinux for JDK17 & 19 |
The changes follow the same rules on the struct-based test cases on Windows & zLinux, in which case the struct padding is not required in upcall. In addition to that, part of test cases in JDK17 are updated to remove the unused test code in upcall. Fixes: eclipse-openj9#16619 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
ChengJin01
force-pushed
the
ffi_test_remove_struct_padding_win_zlinux
branch
from
75514cc
to
19d8dd3
Compare
tajila
approved these changes
Jan 30, 2023
|
jenkins test sanity zlinux,win jdk19 |
|
I didn't see any test failure at https://openj9-jenkins.osuosl.org/job/Test_openjdk19_j9_sanity.functional_x86-64_windows_Personal/90/tapResults/ or https://openj9-artifactory.osuosl.org/artifactory/ci-openj9/Test/Test_openjdk19_j9_sanity.functional_x86-64_windows_Personal/90/ Not sure why |
|
There was an infra failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes follow the same rules on the struct-based test cases on Windows & zLinux,
in which case the struct padding is not required in upcall. In addition to that, part of test
cases in JDK17 are updated to remove the unused test code in upcall.
Fixes: #16619
Signed-off-by: ChengJin01 jincheng@ca.ibm.com