Use JNI refs for virtual thread objects during JVMTI suspend #16661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babsingh
force-pushed
the
fix_vthread_jvmti_suspend
branch
4 times, most recently
from
f6d2a4f
to
2c8cad6
Compare
|
@gacholio Can you please review/merge this PR? |
(jthread)&walkVirtualThread is not a JNI ref, and it will not be updated by the GC when VM access is released in suspendhelper.cpp::suspendThread. Now, JNI refs are used to pass virtual thread objects during JVMTI suspend. This assures that the GC updates them. Related: eclipse-openj9#16593 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
force-pushed
the
fix_vthread_jvmti_suspend
branch
from
2c8cad6
to
745b6e2
Compare
gacholio
approved these changes
Feb 3, 2023
|
jenkins test sanity zlinux jdk19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(jthread)&walkVirtualThread is not a JNI ref, and it will not be
updated by the GC when VM access is released in
suspendhelper.cpp::suspendThread.
Now, JNI refs are used to pass virtual thread objects during JVMTI
suspend. This assures that the GC updates them.
Related: #16593
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com