[FFI] Remove the restriction on all sessions in downcall #16663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes remove the restriction for any session regardless of the session's type to ensure the memory of upcall stub is kept alive during the downcall. Fixes: eclipse-openj9#16606 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
|
As explained at #16606 (comment), we remove the restriction on the shared session (including implicit/global sessions) by checking its onwer thread (which is null for any shared session which is shared by threads) to ensure any allocated region (including the memory allocated for the upcall stub) is kept alive during the downcall. |
ChengJin01
added
comp:vm
project:panama
tajila
approved these changes
Feb 3, 2023
tajila
reviewed
Feb 3, 2023
jcl/src/java.base/share/classes/openj9/internal/foreign/abi/InternalDowncallHandler.java
Show resolved
Hide resolved
|
jenkins test sanity plinux jdk19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes remove the restriction for any session regardless of the session's type
to ensure the memory of upcall stub is kept alive during the downcall.
Fixes: #16606
Signed-off-by: ChengJin01 jincheng@ca.ibm.com