Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print Version Incompatible message at Server and client when XX:+JITServerLogConnection is specified #16691

Merged
merged 1 commit into from Feb 9, 2023
Merged

Print Version Incompatible message at Server and client when XX:+JITServerLogConnection is specified #16691

merged 1 commit into from Feb 9, 2023

Conversation

SajinaKandy
Copy link
Contributor

@SajinaKandy SajinaKandy commented Feb 8, 2023 •
edited

When XX:+JITServerLogConnection is specified, prints the following messages if the Server and Client java versions are incompatible:

At Server:

JITServer is ready to accept incoming requests
#JITServer: compThreadID=0 stream version incompatible: JITServer expected version 17639447472384 received 17626562570240
#JITServer: t= 16536 Client (clientUID=5313472937869690318) disconnected. Client session not deleted

At Client:
#JITServer: compThreadID=0 JITServer StreamVersionIncompatible: JITServer/JITClient incompatibility detected

Closes: ##16679
Signed-off-by: Sajina Kandy sajina.kandy@ibm.com

@SajinaKandy
Copy link
Contributor Author

@mpirvu Can you please review the changes?

@mpirvu mpirvu self-assigned this Feb 8, 2023
@mpirvu mpirvu added the comp:jitserver Artifacts related to JIT-as-a-Service project label Feb 8, 2023
@mpirvu mpirvu added this to In progress in JIT as a Service via automation Feb 8, 2023
mpirvu
mpirvu reviewed Feb 8, 2023
View reviewed changes
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer the client to show this other message:

#JITServer: compThreadID=0 JITServer StreamVersionIncompatible: JITServer/JITClient incompatibility detected

@SajinaKandy
Print Version Incompatible message at client and server if JITServerL…
b109001 
…ogConnection specified

Closes: #eclipse-openj9#16679
Signed-off-by: Sajina Kandy <sajina.kandy@ibm.com>
mpirvu
mpirvu approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpirvu
Copy link
Contributor

mpirvu commented Feb 8, 2023

jenkins test sanity plinuxjit,xlinuxjit,zlinuxjit jdk17

@mpirvu
Copy link
Contributor

mpirvu commented Feb 9, 2023

jenkins test sanity plinuxjit jdk17

@mpirvu mpirvu merged commit 5c297f7 into eclipse-openj9:master Feb 9, 2023
JIT as a Service automation moved this from In progress to Done Feb 9, 2023
@mpirvu mpirvu mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpirvu mpirvu mpirvu approved these changes

Assignees

@mpirvu mpirvu

Labels
comp:jitserver Artifacts related to JIT-as-a-Service project
Projects
JIT as a Service
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SajinaKandy @mpirvu