Implement methods in com.sun.management.ThreadMXBean #16698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
requested changes
Feb 13, 2023
jcl/src/jdk.management/share/classes/com/sun/management/ThreadMXBean.java
Outdated
Show resolved
Hide resolved
test/functional/JLM_Tests/src/org/openj9/test/java/lang/management/TestThreadMXBean.java
Outdated
Show resolved
Hide resolved
test/functional/JLM_Tests/src/org/openj9/test/java/lang/management/TestThreadMXBean.java
Outdated
Show resolved
Hide resolved
.../jdk.management/share/classes/com/ibm/lang/management/internal/ExtendedThreadMXBeanImpl.java
Show resolved
Hide resolved
pshipton
force-pushed
the
threadmx
branch
2 times, most recently
from
b277e3a
to
a30246d
Compare
keithc-ca
requested changes
Feb 14, 2023
jcl/src/jdk.management/share/classes/com/sun/management/ThreadMXBean.java
Outdated
Show resolved
Hide resolved
test/functional/JLM_Tests/src/org/openj9/test/java/lang/management/TestThreadMXBean.java
Outdated
Show resolved
Hide resolved
|
I believe all the current review comments have been addressed. |
Nm, I see some new ones just added. |
keithc-ca
requested changes
Feb 16, 2023
test/functional/JLM_Tests/src/org/openj9/test/java/lang/management/TestThreadMXBean.java
Show resolved
Hide resolved
Stop stubbing com.sun.management.ThreadMXBean and inherit com.ibm.lang.management.ThreadMXBean from com.sun.management.ThreadMXBean Issue eclipse-openj9#16694 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
|
Jenkins test sanity alinux64 jdk17 |
keithc-ca
approved these changes
Feb 22, 2023
Merged
pshipton
added a commit
to pshipton/openj9
that referenced
this pull request
Mar 28, 2023
It was temporarily added in eclipse-openj9#16698 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop stubbing com.sun.management.ThreadMXBean and inherit
com.ibm.lang.management.ThreadMXBean from
com.sun.management.ThreadMXBean
Fixes #16694
Doc issue eclipse-openj9/openj9-docs#1056
Internal ref 148761