Allow for overriding Simplifier handlers defined by OMR #16738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OMR pull request eclipse/omr#6821 introduces changes to the Simplifier optimization that allows a downstream project to override handlers that are supplied for core OMR opcodes in addition to supplying handlers for opcodes that the downstream project provides. The overriding is performed in the new files SimplifierHandlers.hpp and SimplifierTable.enum. This is a coordinated change that allows OpenJ9 to accommodate the OMR changes without actually taking advantage of the ability to override any simplifier handlers. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
|
Daryl @0xdaryl, may I ask you to review this change? Once approved, it will require a coordinated merge with OMR pull request eclipse/omr#6821, so I've marked it as a work in progress. |
|
Jenkins test sanity all jdk8,jdk11,jdk17 depends eclipse/omr#6821 |
|
Please move this out of draft state. |
0xdaryl
approved these changes
Feb 23, 2023
|
Jenkins test sanity xlinux jdk17 depends eclipse/omr#6821 Previous acceptance test run was successful. As a couple of days has passed since it was run, I'll re-run a sniff test on x Linux before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OMR pull request eclipse/omr#6821 introduces changes to the Simplifier optimization that allows a downstream project to override handlers that are supplied for core OMR opcodes in addition to supplying handlers for opcodes that the downstream project provides. The overriding is performed in the new files SimplifierHandlers.hpp and SimplifierTable.enum.
This is a coordinated change that allows OpenJ9 to accommodate the OMR changes without actually taking advantage of the ability to override any simplifier handlers.