Comp Threads and JIT Server options post restore

[dsouzai]

• Add the concept of Number of Allocated Threads
  • In CRIU mode, the number of threads allocated is TR::CompilationInfo::MAX_CLIENT_USABLE_COMP_THREADS (unless it exceeds the number of code caches).
  • In non-CRIU mode, the number of threads allocated is the same as the number of usable threads.
• Refactor JITServer options processing code so it can be reused post-restore
• Process JITServer options post restore
• Enable the post restore options processing code

[dsouzai]

It is worth noting that this may need to be changed in the future to account for the fact that in CRIU mode, JITServer is only enabled by default in non-portable mode (#15674)

[dsouzai]

@mpirvu could you please review?

[dsouzai]

@vijaysun-omr fyi

[mpirvu]

I have some inline comments

[dsouzai]

@mpirvu good for review again (see force push). I updated setNumUsableCompilationThreadsPostRestore to take in the parameter by reference so that it updates TR::Options::_numUsableCompilationThreads; this ensures that we do the check you mentioned in #16769 (comment).

Also, I added the code to actually run this code post restore so that we start exercising this stuff.

[mpirvu]

I have a few more suggestions. Please see inline.

[dsouzai]

@mpirvu addressed review comments (see force push).

Also I ran some tests:

Specifying nothing (defaults to localhost) or the machine name:

#CHECKPOINT RESTORE: Done compiling methods for checkpoint
#CHECKPOINT RESTORE: Preparing to suspend threads for checkpoint
#CHECKPOINT RESTORE: Finished suspending threads for checkpoint
#CHECKPOINT RESTORE: Ready for checkpoint
#CHECKPOINT RESTORE: Preparing for restore
#CHECKPOINT RESTORE: Ready for restore
...
 (warm) Compiling HelloInstantOn.jitMe()V  OrdinaryMethod j9m=0000000000191700 remote t=15206 compThreadID=3 memLimit=1572864 KB freePhysicalMemory=1534 MB
#JITServer: Client sending compReq seqNo=1 to server for method HelloInstantOn.jitMe()V @ warm.
#JITServer: t= 15206 Connected to a server (serverUID=17563505271461179976)
#JITServer: Client successfully loaded method HelloInstantOn.jitMe()V @ warm following compilation request. [metaData=00007F3848A86038, startPC=00007F3D812B4058]
+ (warm) HelloInstantOn.jitMe()V @ 00007F3D812B4058-00007F3D812B48E8 OrdinaryMethod - Q_SZ=3 Q_SZI=3 QW=26 j9m=0000000000191700 bcsz=23 OSR remote time=86227us mem=[region=448 system=2048]KB compThreadID=3 CpuLoad=0%(0%avg) JvmCpu=55% queueTime=86978us

Specifying -XX:JITServerAddress=badaddr:

#CHECKPOINT RESTORE: Done compiling methods for checkpoint
#CHECKPOINT RESTORE: Preparing to suspend threads for checkpoint
#CHECKPOINT RESTORE: Finished suspending threads for checkpoint
#CHECKPOINT RESTORE: Ready for checkpoint
#CHECKPOINT RESTORE: Preparing for restore
#CHECKPOINT RESTORE: Ready for restore
...
 (warm) Compiling HelloInstantOn.jitMe()V  OrdinaryMethod j9m=0000000000191700 remote t=9436 compThreadID=4 memLimit=1572864 KB freePhysicalMemory=1523 MB
#FAILURE:  JITServer::StreamFailure: Cannot resolve server name: Name or service not known for HelloInstantOn.jitMe()V @ warm
#JITServer: t=  9436 Could not connect to a server. Next attempt in 2000 ms.
#JITServer: t=  9436 Resetting activation policy to AGGRESSIVE because client has lost connection to server
#JITServer: compThreadID=4 JITServer StreamFailure: Generic stream failure
! (warm) HelloInstantOn.jitMe()V Q_SZ=3 Q_SZI=3 QW=26 j9m=0000000000191700 time=29751us compilationStreamFailure memLimit=1572864 KB freePhysicalMemory=1523 MB mem=[region=64 system=2048]KB compThreadID=4
 (warm) Compiling HelloInstantOn.jitMe()V  OrdinaryMethod j9m=0000000000191700  t=9436 compThreadID=4 memLimit=1572864 KB freePhysicalMemory=1523 MB
+ (warm) HelloInstantOn.jitMe()V @ 00007FEF322B4058-00007FEF322B4801 OrdinaryMethod - Q_SZ=3 Q_SZI=3 QW=26 j9m=0000000000191700 bcsz=23 OSR time=20324us mem=[region=3968 system=4096]KB compThreadID=4 CpuLoad=0%(0%avg) JvmCpu=76% queueTime=50911us

[mpirvu]

jenkins test sanity all jdk17