Test result of arraycmp for value type comparison #16776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Leaving this as a draft pull request while running tests. |
a7ehuo
reviewed
Feb 27, 2023
|
Thanks, Annabelle @a7ehuo! I have adjusted the comments in commit 5555dc7cdbe1aef429959c6471286298fc4efd4e. If you are OK with those changes, I will squash the commits. |
a7ehuo
approved these changes
Feb 28, 2023
LGTM. I've approved the change |
The arraycmp operation produces a result of zero if the memory being
compared is equal, one if the first operand is less than second, or two
if the second operand is less than the first. The transformation of
<object{Equality|Inequality}Comparison> used arraycmp assuming that the
result would be zero for equality or one for inequality. This change
adds an icmpeq or icmpne to compare the result of the arraycmp with zero
in order to yield a value in the expected range: {0,1}.
Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
hzongaro
force-pushed
the
test-arraycmp-result-for-value-type
branch
from
5555dc7
to
1bbd087
Compare
|
Squashed these changes into commit 1bbd087 |
|
Jenkins test sanity xlinuxval jdknext |
|
Jenkins test sanity all jdk17 |
hzongaro
added
comp:jit
project:valhalla
|
@0xdaryl Daryl, have you had a chance to look at this change? |
0xdaryl
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
arraycmpoperation produces a result of zero if the memory being compared is equal, one if the first operand is less than the second, or two if the second operand is less than the first. The transformation of<object{Equality|Inequality}Comparison>usedarraycmpassuming that the result would be zero for equality or one for inequality. This change adds anicmpeqoricmpneto compare the result of thearraycmpwith zero in order to yield a value in the expected range: {0,1}.