Infrastructure for EDO profiling optimization #16799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `HasEdoSnippet` flag in `TR_PersistentJittedBodyInfo` which is set when the codegen generates an EDO recompilation snippet (such snippet decrements `TR_PersistentJittedBodyInfo._counter` whenever a catch block is entered). Added new reason for recompilation in `TR_PersistentMethodInfo` called `RecompDueToEdo` which is set when a recompilation is triggered from the snippet mentioned above. Verbose log will show "E" (from EDO) as the reason for recompilation when the recompilation was triggered by EDO. Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
This counter is supposed to be incremented by jitted code every time a catch block is entered. The value of the counter should be inspected by the Inliner to determine whether it should inline more aggressively on the throw path in order to transform a throw into a goto operation. Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
|
@ymanton could you please review/merge this relatively simple PR? Thanks |
ymanton
approved these changes
Mar 1, 2023
Yes, I plan to deliver a subsequent omr PR with some other infra and then another openj9 PR with the code that exploits the infra created. |
|
Jenkins test sanity.functional all jdk11 |
|
AIX has this infra failure: |
|
Jenkins test sanity.functional aix jdk11 |
|
All tests have passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation of EDO (Exception Directed Optimization) required 3 compilations to take advantage of the optimization:
We want to take advantage of EDO with just two compilations, by combining the first two steps into one.
This means that every method will now do catch block profiling. This should not have too much overhead because we only insert one increment operation in the catch block and the overhead of an exception is far greater than this extra instruction.
This PR implements the infrastructure required for the mechanism above.
_catchBlockCounterfield inTR_PersistentMethodInfothat will be used for profilingThe PR also removes the code for the
ThresholdCompilationStrategywhich has been unused for years now.Because this cleanup commit removed a counter from
TR_PersistentMethodInfo, there is no footprint impact from this PR as a whole.