(0.37) Invoke VirtualThread J9Hooks after releasing VirtualThread List Mutex #16857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VirtualThread J9Hooks trigger callbacks which can utilize JVMTI RawMonitors. The usage of JVMTI RawMonitors can conflict with the J9JavaVM->liveVirtualThreadListMutex and lead to deadlocks. So, these J9Hooks should be invoked after the liveVirtualThreadListMutex is released to avoid deadlocks. Related: eclipse-openj9#16826 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
force-pushed
the
pin_vt_jvmti_monitor_funcs_v37
branch
from
efa7679
to
943985f
Compare
gacholio
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VirtualThread J9Hooks trigger callbacks which can utilize JVMTI
RawMonitors. The usage of JVMTI RawMonitors can conflict with the
J9JavaVM->liveVirtualThreadListMutex and lead to deadlocks. So,
these J9Hooks should be invoked after the liveVirtualThreadListMutex
is released to avoid deadlocks.
Related: #16826
Backport of #16856