(0.37) Pass valid JNI refs to getVirtualThreadState #16878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(jthread)&threadObject is not a JNI ref, and it will not be updated by the GC when VM access is released in jvmtiHelpers.c::getVirtualThreadState. Non-null thread refs are directly passed to getVirtualThreadState. A local ref is created for currentThread->threadObject before it is passed to getVirtualThreadState. This assures that the GC updates the virtual thread object which is passed to getVirtualThreadState. In getVirtualThreadState, the virtual thread object is refected after VM access is re-acquired to prevent access to a stale object. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
gacholio
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(jthread)&threadObject is not a JNI ref, and it will not be
updated by the GC when VM access is released in
jvmtiHelpers.c::getVirtualThreadState.
Non-null thread refs are directly passed to getVirtualThreadState.
A local ref is created for currentThread->threadObject before it is
passed to getVirtualThreadState. This assures that the GC updates
the virtual thread object which is passed to getVirtualThreadState.
In getVirtualThreadState, the virtual thread object is refected
after VM access is re-acquired to prevent access to a stale object.
Backport of #16877