Update IBM copyright notices to remove last-modified year #16881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no longer any need to update the year in the copyright notice at the top of each modified file. The copyright/license file header template is updated so that the copyright notice in it will be consistent with the IBM copyright notices in most files (once they are updated in a subsequent commit).
Instead of the actual last-modified year, the code generators/template
files contain a placeholder or variable to be filled in, or simply code
that determines the current year, so they will not be updated by the
regular expression search and replace.
Since the focus of this change is source file copyright/license notice
headers, some generated copyright notices are deliberately unchanged:
- Those whose purpose is to be embedded into binaries during the build,
e.g. copyright.c.{in,ftl}, Windows LegalCopyright metadata.
- Those in Javadoc configuration files.
- J9_COPYRIGHT_STRING, which is printed to stdout for users to see.
- Reintroduce paragraph breaks and re-wrap to match other files in methodvisibilitytests.xml and testUnreflect.xml. - Remove a misleading extra notice from TriggerDumpTracePoint.java. It was mistakenly left in place when the file was contributed to OpenJ9. But since it said 2009, update the initial date accordingly.
This commit was generated by a perl regular expression substitution of:
Copyright \(c\) (?<year>\d+)(?:, \d+)? (?<who>IBM Corp\.(?: and others\b)?)
for:
Copyright $+{who} $+{year}
|
eclipse/omr#6923 (comment) applies to this PR as well |
dsouzai
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
I reviewed a sample of the files manually. Since the script used to generate the copyright update commit is the same as the one used in eclipse/omr#6923, it has already been reviewed and shown to be correct. As with the OMR PR, I ran the script used to generate the copyrights and verified that the commit it generates is exactly the same as Update IBM copyright notices to remove last-modified year.
|
jenkins test sanity all jdk17 |
|
AIX failure is #8625: |
|
Jenkins test sanity aix jdk17 |
|
The Pull Request job shows as failed because the AIX build failed in https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/3470/ (as described in #16881 (comment)); however, the job Devin started (https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/3471/) passed. |
This was referenced Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the last-modified year removed, PRs no longer need to ensure that it is up-to-date.
The bulk of this change is in the last commit, which has been generated based on a regex substitution. It modifies the vast majority of files in the repository (though only one line in all but a few). There are some much smaller commits leading up to that one. The full list of commits is as follows:
Because the last commit touches so many files, it's tricky to review. I left some suggestions for how to review the corresponding OMR commit in eclipse/omr#6923. Here I've used the same regex substitution script that I posted there.
In the event of conflicts, I will rebase and regenerate the last commit.
Fixes #16669