Cache Security Algorithms For CRIU Startup #16888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonkatonica
changed the title
keithc-ca
requested changes
Mar 13, 2023
jcl/src/java.base/share/classes/openj9/internal/criu/security/CRIUConfigurator.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/criu/security/CRIUConfigurator.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/criu/security/CRIUConfigurator.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/criu/security/CRIUConfigurator.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/criu/security/CRIUConfigurator.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/criu/security/CRIUConfigurator.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/criu/security/CRIUConfigurator.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/criu/security/CRIUConfigurator.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/criu/security/CRIUConfigurator.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/criu/security/CRIUConfigurator.java
Outdated
Show resolved
Hide resolved
jasonkatonica
changed the title
keithc-ca
requested changes
Mar 16, 2023
jcl/src/java.base/share/classes/openj9/internal/criu/security/CRIUConfigurator.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/criu/security/CRIUConfigurator.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/criu/security/CRIUConfigurator.java
Outdated
Show resolved
Hide resolved
keithc-ca
reviewed
Mar 16, 2023
jcl/src/java.base/share/classes/openj9/internal/criu/security/CRIUConfigurator.java
Outdated
Show resolved
Hide resolved
When making use of the CRIU feature for a fast startup it has been found that fetching algorithms is quite slow from the providers installed. This update saves all algorithms available in all providers prior to a checkpoint being taken. This cache then becomes available for callers after a restore has taken place. Any updates to the security providers order made via the Security classes triggers the invalidation of this cache.
|
Jenkins test sanity xlinux jdk17 |
jasonkatonica
added a commit
to jasonkatonica/openj9-openjdk-jdk11
that referenced
this pull request
Mar 17, 2023
that fetching algorithms is quite slow from the providers installed. This update saves all algorithms available in all providers prior to a checkpoint being taken. This cache then becomes available for callers after a restore has taken place. Any updates to the security providers order made via the Security classes triggers the invalidation of this cache. This update is dependent upon: eclipse-openj9/openj9#16888 Signed-off-by: Jason Katonica katonica@us.ibm.com
jasonkatonica
added a commit
to jasonkatonica/openj9-openjdk-jdk17
that referenced
this pull request
Mar 17, 2023
that fetching algorithms is quite slow from the providers installed. This update saves all algorithms available in all providers prior to a checkpoint being taken. This cache then becomes available for callers after a restore has taken place. Any updates to the security providers order made via the Security classes triggers the invalidation of this cache. This update is dependent upon: eclipse-openj9/openj9#16888 Signed-off-by: Jason Katonica katonica@us.ibm.com
jasonkatonica
added a commit
to jasonkatonica/openj9-openjdk-jdk11
that referenced
this pull request
Mar 17, 2023
When making use of the CRIU feature for a fast startup it has been found that fetching algorithms is quite slow from the providers installed. This update saves all algorithms available in all providers prior to a checkpoint being taken. This cache then becomes available for callers after a restore has taken place. Any updates to the security providers order made via the Security classes triggers the invalidation of this cache. This update is dependent upon: eclipse-openj9/openj9#16888 Signed-off-by: Jason Katonica katonica@us.ibm.com
jasonkatonica
added a commit
to jasonkatonica/openj9-openjdk-jdk17
that referenced
this pull request
Mar 17, 2023
When making use of the CRIU feature for a fast startup it has been found that fetching algorithms is quite slow from the providers installed. This update saves all algorithms available in all providers prior to a checkpoint being taken. This cache then becomes available for callers after a restore has taken place. Any updates to the security providers order made via the Security classes triggers the invalidation of this cache. This update is dependent upon: eclipse-openj9/openj9#16888 Signed-off-by: Jason Katonica katonica@us.ibm.com
jasonkatonica
added a commit
to jasonkatonica/openj9-openjdk-jdk11
that referenced
this pull request
Mar 17, 2023
When making use of the CRIU feature for a fast startup it has been found that fetching algorithms is quite slow from the providers installed. This update saves all algorithms available in all providers prior to a checkpoint being taken. This cache then becomes available for callers after a restore has taken place. Any updates to the security providers order made via the Security classes triggers the invalidation of this cache. This update is dependent upon: eclipse-openj9/openj9#16888 Signed-off-by: Jason Katonica katonica@us.ibm.com
jasonkatonica
added a commit
to jasonkatonica/openj9-openjdk-jdk17
that referenced
this pull request
Mar 17, 2023
When making use of the CRIU feature for a fast startup it has been found that fetching algorithms is quite slow from the providers installed. This update saves all algorithms available in all providers prior to a checkpoint being taken. This cache then becomes available for callers after a restore has taken place. Any updates to the security providers order made via the Security classes triggers the invalidation of this cache. This update is dependent upon: eclipse-openj9/openj9#16888 Signed-off-by: Jason Katonica katonica@us.ibm.com
This was referenced Mar 17, 2023
keithc-ca
approved these changes
Mar 17, 2023
|
Is this change supposed to go into the 0.38 release? The extension changes went in, but not this one, so the builds are failing. |
|
Yes we need this in 0.38 |
|
@jasonkatonica Please open a PR for 0.38 |
|
Just opened a PR against branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making use of the CRIU feature for a fast startup it has been found
that fetching algorithms is quite slow from the providers installed.
This update saves all algorithms available in all providers prior to
a checkpoint being taken. This cache then becomes available for callers
after a restore has taken place.
Any updates to the security providers order made via the Security
classes triggers the invalidation of this cache.
This update is needed for ibmruntimes/openj9-openjdk-jdk#565
Signed-off-by: Jason Katonica katonica@us.ibm.com