Update common.mk to compile new OMR Register Allocator files #16912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OMR pull request eclipse/omr#6577 renames RegisterCandidate.cpp to OMRRegisterCandidate.cpp, and adds a new file, OMRGlobalRegister.cpp. Both of these files are located in omr/compiler/optimizer. This change updates the OpenJ9 common.mk file that is used by older versions of the build infrastructure to compile those files. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
|
This change needs to be merged in coordination with OMR pull request 6577. I will leave this in Draft status until late review comments on that pull request are addressed. |
|
Daryl @0xdaryl, may I ask you to review this change? It's the OpenJ9 change that needs to accompany OMR pull request eclipse/omr#6577 |
|
Jenkins test sanity all jdk8,jdk17,jdk19 depends eclipse/omr#6577 |
0xdaryl
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OMR pull request eclipse/omr#6577 renames
RegisterCandidate.cpptoOMRRegisterCandidate.cpp, and adds a new file,OMRGlobalRegister.cpp. Both of these files are located inomr/compiler/optimizer. This change updates the OpenJ9common.mkfile that is used by older versions of the build infrastructure to compile those files.