Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate compiles if -Xdump on exception is specified post restore #16928

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

dsouzai
Copy link
Contributor

@dsouzai dsouzai commented Mar 15, 2023

If -Xdump is specified to dump on exception post-restore (but not pre-checkpoint), then invalidate all compilations, since they will not have been generated to support it.

@dsouzai dsouzai added comp:jit criu Used to track CRIU snapshot related work labels Mar 15, 2023
@dsouzai
Copy link
Contributor Author

dsouzai commented Mar 15, 2023

@mpirvu could you please review? This is essentially the same approach taken in #16852

fyi @vijaysun-omr

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
@mpirvu mpirvu self-assigned this Mar 15, 2023
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpirvu
Copy link
Contributor

mpirvu commented Mar 15, 2023

jenkins test sanity all jdk17

@mpirvu
Copy link
Contributor

mpirvu commented Mar 16, 2023

jenkins test sanity aix jdk17

@mpirvu
Copy link
Contributor

mpirvu commented Mar 16, 2023

Tests have passed, hence merging.

@mpirvu mpirvu merged commit 1bd783b into eclipse-openj9:master Mar 16, 2023
@dsouzai dsouzai deleted the postRestoreOptions branch April 3, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jit criu Used to track CRIU snapshot related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants