(0.38) Add support for -Xrs on restore #16933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds support for -Xrs on restore. Given that its imposible to support -Xrs in the same manner on restore that it is supported at startup (because there may be frames on the stack with signal handlers already installed that cannot be removed on restore) this change requires that "onRestore" is appended to the option. For example: -Xrs:sync -> -Xrs:syncOnRestore, -Xrs -> -Xrs:onRestore, .. Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
|
@babsingh please review/merge |
tajila
changed the title
babsingh
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for -Xrs on restore
This PR adds support for -Xrs on restore. Given that its imposible to support -Xrs in the same manner on restore that it is supported at startup (because there may be frames on the stack with signal handlers already installed that cannot be removed on restore) this change requires that "onRestore" is appended to the option.
backport of #16919
For example: -Xrs:sync -> -Xrs:syncOnRestore, -Xrs -> -Xrs:onRestore, ..