Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the product name in the DTFJ JavaRuntime version #16941

Merged
merged 1 commit into from
Mar 18, 2023
Merged

Include the product name in the DTFJ JavaRuntime version #16941

merged 1 commit into from
Mar 18, 2023

Conversation

pshipton
Copy link
Member

@pshipton pshipton commented Mar 16, 2023 •
edited

The jdmpview info system output includes the JavaRuntime version. Also include the product name in the !coreinfo output.

Only OpenJ9 builds have a product name.

Closes #16930

@pshipton pshipton requested a review from keithc-ca March 16, 2023 22:30
@pshipton pshipton force-pushed the dsysprops branch 2 times, most recently from 0043db9 to bc283d3 Compare March 17, 2023 02:11
@pshipton
Copy link
Member Author

Addressed the review comments.

@keithc-ca
Copy link
Contributor

Jenkins compile alinux64 jdk17

@keithc-ca
Copy link
Contributor

This isn't quite done. Running !coreinfo on a core generated by "Eclipse OpenJ9 VM 11.0.17.0 (build openj9-0.35.0)" yields

	*0 : PID: 441798 : Exception in thread "main" java.lang.NoSuchMethodError: com/ibm/j9ddr/vm29/pointer/generated/J9RASPointer.productName()Lcom/ibm/j9ddr/vm29/pointer/U8Pointer; (loaded from <Unknown> by J9DDRClassloader for com.ibm.j9ddr.vm29.) called from class com.ibm.j9ddr.vm29.view.dtfj.java.DTFJJavaRuntime (loaded from <Unknown> by J9DDRClassloader for com.ibm.j9ddr.vm29.).
	at com.ibm.j9ddr.vm29.view.dtfj.java.DTFJJavaRuntime.getVersion(DTFJJavaRuntime.java:939)
	at openj9.dtfjview/com.ibm.jvm.dtfjview.CombinedContext.getJREVersion(CombinedContext.java:313)
	at openj9.dtfjview/com.ibm.jvm.dtfjview.CombinedContext.displayContext(CombinedContext.java:291)
	at openj9.dtfjview/com.ibm.jvm.dtfjview.Session.showContexts(Session.java:306)
	at openj9.dtfjview/com.ibm.jvm.dtfjview.Session.runBatch(Session.java:687)
	at openj9.dtfjview/com.ibm.jvm.dtfjview.Session.run(Session.java:667)
	at openj9.dtfjview/com.ibm.jvm.dtfjview.DTFJView.launch(DTFJView.java:52)
	at openj9.dtfjview/com.ibm.jvm.dtfjview.DTFJView.main(DTFJView.java:46)

@keithc-ca
Copy link
Contributor

The line in AuxFieldInfo29.dat needs to be

J9RAS.productName = U8*

@pshipton
Include the product name in the DTFJ JavaRuntime version
abc01f4 
The jdmpview `info system` output includes the JavaRuntime version.
Also include the product name in the !coreinfo output.

Only OpenJ9 builds have a product name.

Issue eclipse-openj9#16930

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton
Copy link
Member Author

Updated it and it's working now.

keithc-ca
keithc-ca approved these changes Mar 18, 2023
View reviewed changes
Copy link
Contributor

@keithc-ca keithc-ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build succeeded (https://openj9-jenkins.osuosl.org/view/Pull%20Requests/job/PullRequest-OpenJ9/3525/) and I verified locally that the latest change addresses the problem accessing older core files.

@keithc-ca keithc-ca merged commit 34daf46 into eclipse-openj9:master Mar 18, 2023
@pshipton pshipton mentioned this pull request Mar 21, 2023
Merged
@pshipton pshipton mentioned this pull request May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithc-ca keithc-ca keithc-ca approved these changes

Assignees
No one assigned
Labels
comp:vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show Semeru Open/Certified Edition in coredump
2 participants
@pshipton @keithc-ca