Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sharedCacheAPI to determine -Xshareclasses:disableOnRestore #16972

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

dsouzai
Copy link
Contributor

@dsouzai dsouzai commented Mar 20, 2023

The VM sets vm->sharedCacheAPI->xShareClassCacheDisabledOnCRIURestore when -Xshareclasses:disableOnRestore post-restore. Rather than parsing the option directly, the compiler should just use this field.

The VM sets
vm->sharedCacheAPI->xShareClassCacheDisabledOnCRIURestore
when -Xshareclasses:disableOnRestore post-restore. Rather than parsing
the option directly, the compiler should just use this field.

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
@dsouzai dsouzai added comp:jit comp:jit:aot criu Used to track CRIU snapshot related work labels Mar 20, 2023
@dsouzai
Copy link
Contributor Author

dsouzai commented Mar 20, 2023

@ymanton could you please review/merge?

Copy link
Member

@ymanton ymanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ymanton
Copy link
Member

ymanton commented Mar 21, 2023

Jenkins test sanity.functional xlinux jdk11,jdk17

@ymanton ymanton merged commit 13f9b4c into eclipse-openj9:master Mar 21, 2023
@dsouzai dsouzai mentioned this pull request Mar 24, 2023
31 tasks
@dsouzai dsouzai deleted the sccDisableCleanup branch April 3, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jit:aot comp:jit criu Used to track CRIU snapshot related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants