Disable FFI specific test suites for JDK21 #17013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems there is no compilation failure detected in OpenJ9 for the new changes at ibmruntimes/openj9-openjdk-jdk#572, which suggests that there is no change for the public APIs given it should be an interim version which doesn't reflect the finalized changes of JDK21 as specified #16951. For safety reason, we still need to disable all related code and test suites for the moment and scrutinize all of them to see what needs to be updated accordingly to accommodate the new changes. |
ChengJin01
added
comp:test
project:panama
ChengJin01
force-pushed
the
ffi_disable_code_tests_for_new_changes_jdk21
branch
from
4a280d4
to
cfa787d
Compare
ChengJin01
changed the title
|
I re-enabled the JCL changes in OpenJ9 as explained at ibmruntimes/openj9-openjdk-jdk#572 (comment) given there is no compilation failure when creating the build, which suggests that the majority of changes happen in OpenJDK. |
keithc-ca
reviewed
Mar 24, 2023
The changes temporarily disable all FFI specific test suites as we might need to update them accordingly in OpenJDK & OpenJ9 once the new changes for OpenJDK are merged to the HEAD repository. Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
ChengJin01
force-pushed
the
ffi_disable_code_tests_for_new_changes_jdk21
branch
from
cfa787d
to
46344bf
Compare
keithc-ca
approved these changes
Mar 24, 2023
tajila
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes temporarily disable all FFI specific
test suites as we might need to update them
accordingly in OpenJDK & OpenJ9 once the new
changes for OpenJDK are merged to the HEAD
repository.
Signed-off-by: ChengJin01 jincheng@ca.ibm.com