(v0.37.0-release) Remove setImmutableField on currentThread for JDK19 and up #17021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Thread.currentThread` can be changed by JCL in JDK19 and up. Set it as volatile for JDK19 and up. Add `isJ9VMThreadCurrentThreadImmutable` in FrontEnd to query whether or not `Thread.currentThread` is immutable based on `JAVA_SPEC_VERSION`. Fixes eclipse-openj9#16258 Co-authored-by: Daryl Maier <maier@ca.ibm.com> Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
|
@0xdaryl Ready for review. Thanks! |
0xdaryl
approved these changes
Mar 24, 2023
|
@pshipton : I approved this. It can be merged anytime you want it. I wasn't sure if you wanted the master PR to go through a full test cycle or not first. It is generally a safe fix that only makes things more conservative. |
pshipton
approved these changes
Mar 24, 2023
|
I'd rather have it in so it goes through weekend testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread.currentThreadcan be changed by JCL in JDK19 and up. Set it as volatile for JDK19 and up.Add
isJ9VMThreadCurrentThreadImmutablein FrontEnd to query whether or notThread.currentThreadis immutable based onJAVA_SPEC_VERSION.Cherry-picked:
Fixes #16258