Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-generate client UID after CRIU restore operation (0.38.0) #17061

Merged
merged 1 commit into from Mar 29, 2023

Conversation

mpirvu
Copy link
Contributor

@mpirvu mpirvu commented Mar 29, 2023

With JITServer Technology, each client JVM has a unique ID that is generated during JVM bootstrap. When checkpointing a JVM that is supposed to be used in client mode, this client UID gets baked into the JVM snapshot, and all JVM processes that are restored from this snapshot will have the same UID, which confuses the server. This comit re-generates the client UID during the snapshot restore operation so that different clients will have different UIDs.

Issue: #17022

With JITServer Technology, each client JVM has a unique ID that
is generated during JVM bootstrap. When checkpointing a JVM that
is supposed to be used in client mode, this client UID gets
baked into the JVM snapshot, and all JVM processes that are restored
from this snapshot will have the same UID, which confuses the server.
This comit re-generates the client UID during the snapshot restore
operation so that different clients will have different UIDs.

Issue: eclipse-openj9#17022

Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
@mpirvu mpirvu added comp:jitserver Artifacts related to JIT-as-a-Service project criu Used to track CRIU snapshot related work labels Mar 29, 2023
@mpirvu
Copy link
Contributor Author

mpirvu commented Mar 29, 2023

This is a cherry-pick of commit 2de3634 from PR #17043
The change can only affect JVMs restored from a snapshot when used in client mode (connecting to a JITServer instance)

@mpirvu
Copy link
Contributor Author

mpirvu commented Mar 29, 2023

@dsouzai Could you please approve and merge this PR into 0.38.0? Thanks

Copy link
Contributor

@dsouzai dsouzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch is identical to 2de3634

@dsouzai dsouzai merged commit 23a928a into eclipse-openj9:v0.38.0-release Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jitserver Artifacts related to JIT-as-a-Service project criu Used to track CRIU snapshot related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants