Update GC DDR to Remove Unused GC MemoryPoolHybrid #17106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RSalman
added a commit
to RSalman/omr
that referenced
this pull request
Apr 4, 2023
- Delete MemoryPoolHybrid.hpp/cpp files - Remove Hybrid Pool specific _heapFreeListCountExtended field from base class MM_MemoryPoolSplitAddressOrderedListBase Depends on: eclipse-openj9/openj9#17106 Signed-off-by: Salman Rana <salman.rana@ibm.com>
|
@dmitripivkine @amicic please have a look |
MemoryPoolHybrid is being removed in OMR, all references to it must also be removed in OpenJ9. Signed-off-by: Salman Rana <salman.rana@ibm.com>
RSalman
added a commit
to RSalman/omr
that referenced
this pull request
Apr 4, 2023
- Delete MemoryPoolHybrid.hpp/cpp files - Remove Hybrid Pool specific _heapFreeListCountExtended field from base class MM_MemoryPoolSplitAddressOrderedListBase Depends on: eclipse-openj9/openj9#17106 Signed-off-by: Salman Rana <salman.rana@ibm.com>
|
cc: @keithc-ca |
amicic
approved these changes
Apr 4, 2023
|
Running some personal builds to verify this won't break anything, will update the PR once everything looks good. |
keithc-ca
reviewed
Apr 4, 2023
Comment on lines
-118
to
-128
| class DDR_MM_MemoryPoolHybrid : public MM_MemoryPoolHybrid | ||
| { | ||
| public: | ||
| const char * ddrHelper(); | ||
| }; | ||
|
|
||
| const char * | ||
| DDR_MM_MemoryPoolHybrid::ddrHelper() | ||
| { | ||
| return this->_typeId; | ||
| } |
There was a problem hiding this comment.
My only potential concern is if this was required to force the compiler to properly describe some ancestor class of MM_MemoryPoolHybrid. We'll need to pay close attention to any effects this has on AIX builds.
There was a problem hiding this comment.
All builds pass, no issues (Axxon: /build_info.php?build_id=48521)
|
Jenkins compile aix jdk8,jdk17 |
amicic
approved these changes
Apr 5, 2023
keithc-ca
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GC MemoryPoolHybrid is being removed in OMR, all references to it must also be removed in OpenJ9.
Signed-off-by: Salman Rana salman.rana@ibm.com