Refactor GC CRIU Routines #17145
Refactor GC CRIU Routines #17145
Conversation
|
@amicic could you please have a look |
RSalman
changed the title
RSalman
force-pushed
the
criu-modron-refac
branch
from
6d7c9a5
to
c51b927
Compare
|
should we expand the logic on dispatcher too and rename expandThreadPool to reinitializeForRestore (and something similar for contract/checkpoint)? |
|
Yup, it would be nice to align dispatcher functions as well |
RSalman
force-pushed
the
criu-modron-refac
branch
2 times, most recently
from
1888ea3
to
96a33d9
Compare
|
I've made the dispatcher changes, OMR needs to be updated as well |
runtime/gc_base/modronapi.cpp
Outdated
| @@ -1131,6 +1131,9 @@ j9gc_reinitialize_for_restore(J9VMThread *vmThread, const char **nlsMsgFormat) | |||
| J9JavaVM *vm = vmThread->javaVM; | |||
| J9MemoryManagerVerboseInterface *mmFuncTable = (J9MemoryManagerVerboseInterface *)vm->memoryManagerFunctions->getVerboseGCFunctionTable(vm); | |||
|
|
|||
| Assert_MM_true(NULL != extensions->getGlobalCollector()); | |||
| Assert_MM_true(NULL != extensions->configuration); | |||
|
|
|||
| PORT_ACCESS_FROM_JAVAVM(vm); | |||
|
|
|||
| if (!j9gc_reinitializeDefaults(vmThread)) { | |||
There was a problem hiding this comment.
noticed this is an inter module method, but it does not seem like it has to be
also should it have 'for restore' in the name ?
btw original method is gcInitializeDefaults (no j9 in the name)
There was a problem hiding this comment.
noticed this is an inter module method, but it does not seem like it has to be
Removed from J9MemoryManagerFunctions
also should it have 'for restore' in the name ?
btw original method is gcInitializeDefaults (no j9 in the name)
Changed j9gc_reinitializeDefaults -> gcReinitializeDefaultsForRestore
Update GC CRIU checkpoint and restore routines based on refactoring done in upstream OMR: eclipse/omr#6947. - Replace configuration reinitializeGCThreadCountForRestore and adjustGCThreadCountForCheckpoint calls with single reinitializeForRestore call. - Invoke the dispatcher directly to expand/contract thread pool - Update the GC thread count in j9gc_reinitializeDefaults Depends on eclipse/omr#6947 Signed-off-by: Salman Rana <salman.rana@ibm.com>
RSalman
force-pushed
the
criu-modron-refac
branch
from
9cdbb9e
to
e1c491d
Compare
|
Jenkins test sanity xlinuxcriu jdk17 |
|
Jenkins compile win jdk8 |
Update GC CRIU checkpoint and restore routines based on refactoring done in upstream OMR: eclipse/omr#6947.
Depends on eclipse/omr#6947
Signed-off-by: Salman Rana salman.rana@ibm.com