Provide JITServer implementation for CRIU specific FE queries (0.38.0) #17151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two frontend queries that are specific to CRIU, `inSnapshotMode()`
and `isSnapshotModeEnabled()` need to be overridden with JITServer
specific implementation that fetches the required information from
the client.
Three new fields were added to the `ClientSessionData.VMInfo` struct
which caches information per client:
bool _inSnapshotMode;
bool _isSnapshotModeEnabled;
bool _isNonPortableRestoreMode;
`_isSnapshotModeEnabled` and `_isNonPortableRestoreMode` can be cached
from the very first response of the client, because they get set when the
VM is initialized and never change their value.
`_inSnapshotMode` requires special handling: if the client runs in
portable restore mode, then this field is always true. If the client runs
in non-portable restore mode, then this field starts as true, but after a
restore, it transitions to false and it stays false until the end of the JVM.
While this field returns 'true', the server must always inquire the client
about the value of this field. After it transitions to `false`, the server
can cache its value and refrain from asking the client again.
For this purpose, a new message type was introduced, `VM_inSnapshotMode`
and the `MINOR_NUMBER` of JITServer has been incremented.
Issue: eclipse-openj9#17117
Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
mpirvu
added
comp:jitserver
|
This is a cherry-pick of #17130 The code that has changed is specific to JITServer and should not affect the stability of non-JITServer environments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two frontend queries that are specific to CRIU,
inSnapshotMode()andisSnapshotModeEnabled()need to be overridden with JITServer specific implementation that fetches the required information from the client.Three new fields were added to the
ClientSessionData.VMInfostruct which caches information per client:bool _inSnapshotMode;
bool _isSnapshotModeEnabled;
bool _isNonPortableRestoreMode;
_isSnapshotModeEnabledand_isNonPortableRestoreModecan be cached from the very first response of the client, because they get set when the VM is initialized and never change their value._inSnapshotModerequires special handling: if the client runs in portable restore mode, then this field is always true. If the client runs in non-portable restore mode, then this field starts as true, but after a restore, it transitions to false and it stays false until the end of the JVM. While this field returns 'true', the server must always inquire the client about the value of this field. After it transitions tofalse, the server can cache its value and refrain from asking the client again. For this purpose, a new message type was introduced,VM_inSnapshotModeand theMINOR_NUMBERof JITServer has been incremented.Issue: #17117