Create prex arg info from callee symbol for array-typed parameters #17168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this type info is missing, validateAndPropagateArgsFromCalleeSymbol() can give up, in which case we can fail to inline even trivial methods due to what appears to be a type incompatibility. In particular, this would cause the actual array access to fail to be inlined for array getter (and probably also setter) MethodHandles.
vijaysun-omr
approved these changes
Apr 19, 2023
|
jenkins test sanity all jdk17 |
|
jenkins test sanity zlinux jdk17 |
|
Checks have passed, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this type info is missing,
validateAndPropagateArgsFromCalleeSymbol()can give up, in which case we can fail to inline even trivial methods due to what appears to be a type incompatibility.In particular, this would cause the actual array access to fail to be inlined for array getter (and probably also setter) MethodHandles.