Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check options on whether or not to inline Thread.currentThread #17182

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Check options on whether or not to inline Thread.currentThread #17182

merged 1 commit into from
Apr 18, 2023

Conversation

a7ehuo
Copy link
Contributor

@a7ehuo a7ehuo commented Apr 13, 2023 •
edited

Check option disableRecognizeCurrentThread and environment variable TR_DisableRecognizeCurrentThread on whether or not to inline Thread.currentThread.

Depends on

@a7ehuo
Check options on whether or not to inline Thread.currentThread
c4b6841 
Check option `disableRecognizeCurrentThread` and environment
variable `TR_DisableRecognizeCurrentThread` on whether or
not to inline T`hread.currentThread`

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo a7ehuo requested a review from 0xdaryl April 13, 2023 15:53
@a7ehuo a7ehuo mentioned this pull request Apr 13, 2023
Merged
@a7ehuo a7ehuo changed the title WIP: Check options on whether or not to inline Thread.currentThread Check options on whether or not to inline Thread.currentThread Apr 14, 2023
@a7ehuo
Copy link
Contributor Author

a7ehuo commented Apr 14, 2023

Removed WIP

@0xdaryl Just a reminder. This PR should be merged only after eclipse/omr#6950 is promoted to openj9-omr

@0xdaryl 0xdaryl self-assigned this Apr 14, 2023
@0xdaryl
Copy link
Contributor

0xdaryl commented Apr 14, 2023

jenkins test sanity all jdk17 depends eclipse/omr#6950

@0xdaryl 0xdaryl removed their assignment Apr 17, 2023
@0xdaryl
Copy link
Contributor

0xdaryl commented Apr 17, 2023

The dependent OMR change is merged but has not promoted yet. @hzongaro (or others) should be able to merge this PR once it does.

@a7ehuo
Copy link
Contributor Author

a7ehuo commented Apr 18, 2023

I see eclipse/omr#6950 has been merged to openj9-omr

@hzongaro
Copy link
Member

As Annabelle @a7ehuo mentioned, the pull request on which this depends has been merged to OpenJ9-OMR. All testing has passed. Merging.

@hzongaro hzongaro merged commit b39a9d2 into eclipse-openj9:master Apr 18, 2023
This was referenced Apr 18, 2023
Closed
Closed
@a7ehuo a7ehuo deleted the add-option-disableRecognizeCurrentThread branch June 6, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzongaro hzongaro hzongaro approved these changes

@0xdaryl 0xdaryl Awaiting requested review from 0xdaryl

Assignees
No one assigned
Labels
comp:jit depends:omr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@a7ehuo @0xdaryl @hzongaro