[FFI] Update the code against the changes in JDK21 #17188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Reviewer: @tajila |
ChengJin01
added
comp:vm
project:panama
ChengJin01
force-pushed
the
ffi_update_code_against_changes_jdk21
branch
from
96983b6
to
6717d9e
Compare
keithc-ca
requested changes
Apr 14, 2023
jcl/src/java.base/share/classes/jdk/internal/foreign/abi/UpcallLinker.java
Outdated
Show resolved
Hide resolved
ChengJin01
force-pushed
the
ffi_update_code_against_changes_jdk21
branch
from
6717d9e
to
6eaa670
Compare
keithc-ca
requested changes
Apr 14, 2023
test/functional/Java21andUp/src/org/openj9/test/jep425/VirtualThreadTests.java
Show resolved
Hide resolved
jcl/src/java.base/share/classes/jdk/internal/foreign/abi/UpcallLinker.java
Show resolved
Hide resolved
jcl/src/java.base/share/classes/jdk/internal/foreign/abi/UpcallLinker.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/jdk/internal/foreign/abi/UpcallLinker.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/jdk/internal/foreign/abi/UpcallLinker.java
Outdated
Show resolved
Hide resolved
ChengJin01
force-pushed
the
ffi_update_code_against_changes_jdk21
branch
2 times, most recently
from
12bdc4b
to
78d367e
Compare
keithc-ca
requested changes
Apr 17, 2023
jcl/src/java.base/share/classes/jdk/internal/foreign/abi/UpcallLinker.java
Outdated
Show resolved
Hide resolved
test/functional/Java21andUp/src/org/openj9/test/jep425/VirtualThreadTests.java
Outdated
Show resolved
Hide resolved
ChengJin01
force-pushed
the
ffi_update_code_against_changes_jdk21
branch
from
78d367e
to
fbd6bef
Compare
keithc-ca
approved these changes
Apr 17, 2023
|
Tested in ibmruntimes/openj9-openjdk-jdk#585. |
tajila
approved these changes
Apr 17, 2023
jcl/src/java.base/share/classes/jdk/internal/foreign/abi/UpcallLinker.java
Outdated
Show resolved
Hide resolved
|
@ChengJin01 small typo We dont need to redo testing for this small change |
The changes implement makeFactory() in UpcallLinker so as to wrap up the existing upcall specific code in CallArranger.arrangeUpcall() with UpcallStubFactory which was introduced in JDK20. Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
ChengJin01
force-pushed
the
ffi_update_code_against_changes_jdk21
branch
from
fbd6bef
to
b858cc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes implement makeFactory() in UpcallLinker
so as to wrap up the existing upcall specific code in
CallArranger.arrangeUpcall() with UpcallStubFactory
which was introduced in JDK20.
Signed-off-by: ChengJin01 jincheng@ca.ibm.com