Close VM and thread libraries on successful DestroyJavaVM #17336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close VM and thread libraries if DestroyJavaVM is successful. Related: eclipse-openj9#17267 Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
|
This has passed an all platforms internal build. |
gacholio
changed the title
|
There are other libraries preloaded as well, should we save the handles so they can also be closed? |
|
Perhaps - if they have globals they could be a problem. |
|
Can I suggest we worry about other libraries in a future PR? This is really meant to address the foolish thread control API that fills in the memory categories (no doubt a result of the J9/OMR disconnect). |
pshipton
approved these changes
May 9, 2023
|
Ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close VM and thread libraries if DestroyJavaVM is successful.
Related: #17267
Signed-off-by: Graham Chapman graham_chapman@ca.ibm.com