Place fatal asserts in FE queries that JITServer should not call #17355
Conversation
The following FE queries: TR_J9VMBase::getReferenceFieldAt(uintptr_t objectPointer, uintptr_t fieldOffset) TR_J9VMBase::getReferenceFieldAtAddress(uintptr_t fieldAddress) TR_J9VMBase::getVolatileReferenceFieldAt(uintptr_t objectPointer, uintptr_t fieldOffset) TR_J9VMBase::getStaticReferenceFieldAtAddress(uintptr_t fieldAddress) are not called by JITServer because they look inside objects and require VM access to prevent objects from being moved by GC. This commit places fatal asserts in the FE queries mentioned above, to make it clear that such queries cannot (and should not) be called by JITServer. Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
|
jenkins test sanity plinuxjit,xlinuxjit,zlinuxjit jdk20 |
|
@jdmpapin When you have time, could you please review/merge this PR? Thanks |
|
Thanks, @mpirvu! I guess this set is sufficient because the other problematic queries take an object address as an argument, and we can't possibly pass an object address to one of those until after we've obtained one, and the first one to be obtained could only have come from one of these disallowed queries. |
|
@jdmpapin gentle reminder to review/merge this PR. Thanks |
|
Oh sorry, I think I thought that I had asked you to confirm my understanding above, but apparently I hadn't. Regardless, I think I understood properly, and you don't seem to have wanted to clarify anything, so I'll go ahead |
|
Changes are JITServer-specific, and JITServer builds have passed |
The following FE queries:
are not called by JITServer because they look inside objects and require VM access to prevent objects from being moved by GC.
This commit places fatal asserts in the FE queries mentioned above, to make it clear that such queries cannot (and should not) be called by JITServer.