Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in JDK11 build instructions #17373

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

jmesyou
Copy link
Contributor

@jmesyou jmesyou commented May 9, 2023

This commit removes an extra set of "```" for a code snippet.

[skip ci]

@pshipton
Copy link
Member

pshipton commented May 9, 2023

Sorry, you need to sign the Eclipse ECA in order for a change to be accepted.

https://github.com/eclipse-openj9/openj9/blob/master/CONTRIBUTING.md

@jmesyou
Copy link
Contributor Author

jmesyou commented May 10, 2023

I mistakenly signed off the commit with the wrong email and I am unable to force the eca check to use the email associated with my eclipsefdn account. I will close this PR and reopen a new one, sorry about that!

@pshipton
Copy link
Member

You can force push a new commit to this PR, you don't need to close it and open a new one.

@pshipton
Copy link
Member

You can force push a new commit to this PR,

By that I mean you can force push a new commit to the docs branch of your fork https://github.com/jmesyou/openj9/

This commit removes an extra set of "```" for a code snippet.

[skip ci]

Signed-off-by: James You <james.you@protonmail.com>
@jmesyou
Copy link
Contributor Author

jmesyou commented May 10, 2023

Fixed!

@pshipton pshipton merged commit 45ed10a into eclipse-openj9:master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants